Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snapshot): mask outside of viewport #30797

Closed
wants to merge 1 commit into from
Closed

fix(snapshot): mask outside of viewport #30797

wants to merge 1 commit into from

Conversation

mxschmitt
Copy link
Member

Fixes #30770

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [firefox-page] › page/page-screenshot.spec.ts:496:7 › page screenshot › mask option › should mask inside
❌ [playwright-test] › playwright.ct-react.spec.ts:253:5 › should pass "key" attribute from JSX in variable

3 flaky ⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [webkit-library] › library/screenshot.spec.ts:75:14 › page screenshot › should work with device scale factor
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

27340 passed, 662 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt mentioned this pull request May 14, 2024
Merged
mxschmitt added a commit that referenced this pull request May 14, 2024
@mxschmitt
Revert "fix(highlight): highlight Top Layer elements (#30001)" (#30800)
b06c1df 
This reverts commit a932222.

Closes #30797 - maybe there
is a better way to get the page height?
`document.documentElement.scrollHeight` seems to not work on Firefox.
Relates #30770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Full page screenshot does not mask element that is outside browser's viewport height
1 participant
@mxschmitt