Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fixtures): attribute teardown step to the right TestInfo instance #29523

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Feb 16, 2024

No description provided.

This comment has been minimized.

@dgozman dgozman force-pushed the tr-fixture-teardown-correct-test-info branch from 39280bf to a165cbf Compare February 16, 2024 19:26

This comment has been minimized.

@dgozman dgozman force-pushed the tr-fixture-teardown-correct-test-info branch from a165cbf to 0e223ea Compare February 16, 2024 20:44

This comment has been minimized.

@dgozman dgozman force-pushed the tr-fixture-teardown-correct-test-info branch from 2181f38 to e7a3ae3 Compare February 17, 2024 04:30

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT

6 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:117:5 › should run component tests after editing test and component
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26574 passed, 613 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit b811df4 into microsoft:main Feb 20, 2024
29 of 30 checks passed
@joeprivettsmart
Copy link

@dgozman I am seeing a lot of these messages "Internal error: fixture integrity at ..." in the terminal. I can see that you added this into the code, but what is this telling me about the fixture - is there a problem with the teardown process? How can I address this problem?

@dgozman
Copy link
Contributor Author

dgozman commented Feb 22, 2024

@joeprivettsmart Could you please file an issue with a repro? Internal error means that something went wrong in the test runner, we would love to fix it!

@joeprivettsmart
Copy link

@joeprivettsmart Could you please file an issue with a repro? Internal error means that something went wrong in the test runner, we would love to fix it!

I can't supply a repo or repro because this is part of a large application, but if you point me in the right direction, I can supply a snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants