fix(fixtures): tear down base fixture after error in derived #29337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
fixture_order
branch
from
cd14473 to
b2d3c2b
Compare
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
fixture_order
branch
from
b2d3c2b to
3d06336
Compare
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
fixture_order
branch
from
3d06336 to
a10104b
Compare
dgozman
approved these changes
Feb 5, 2024
| timeoutManager.setCurrentFixture(this._runnableDescription); | ||
| } | ||
|
|
||
| takeFixturesInTeardownOrder(scope: FixtureScope, collector: Set<Fixture>) { |
There was a problem hiding this comment.
nit: collectFixturesInTeardownOrder?
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
fixture_order
branch
from
a10104b to
932f01e
Compare
Test results for "tests 1"6 flaky26543 passed, 615 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29325