Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): assertValue works with disabled input #29205

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 27, 2024

Also add tests for new codegen functionality.

Fixes #29161.

This comment has been minimized.

Also add tests for new codegen functionality.
@dgozman dgozman force-pushed the codegen-assert-value-disabled branch from 651a97a to b64faf3 Compare January 27, 2024 17:52
Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/workers.spec.ts:106:3 › should clear upon navigation
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

21394 passed, 582 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit acc72c2 into microsoft:main Jan 27, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When the element is disabled, the 'Assert value' tool is unable to generate code
2 participants