fix(test runner): make TestTracing responsible for trace management #29181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
move-trace-to-test-runner
branch
from
25a0eff to
2ebbd40
Compare
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Jan 26, 2024
... instead of a fixture.
dgozman
force-pushed
the
move-trace-to-test-runner
branch
from
2ebbd40 to
8b1e31a
Compare
Test results for "tests 1"3 flaky21367 passed, 581 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of a fixture.
Fixes #29133, fixes #28733, fixes #28476.