Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ct-react): do not reset mount hooks upon update #29072

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

pavelfeldman
Copy link
Member

Fixes #29058

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-component-testing.spec.ts:21:5 › pnpm: @playwright/experimental-ct-react should work

3 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

21295 passed, 579 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit d61f990 into microsoft:main Jan 19, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] on playwright-ct-react update() of a mounted component ignores beforeMount
2 participants