Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce binary size of WebKit Linux build bundles (GTK and WPE) #2880

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

clopez
Copy link
Contributor

@clopez clopez commented Jul 8, 2020

This patch changes the build system to use the JHBuild minimal dependency
system introduced in WebKit r264092 https://trac.webkit.org/r264092

The build has been tested with Ubuntu-18.04

The binary size of the zip bundles is now: 37M (WPE) and 40M (GTK).
Previously it was 54M and 59M (respectively)

@ghost
Copy link

ghost commented Jul 8, 2020

CLA assistant check
All CLA requirements met.

browser_patches/webkit/archive.sh Show resolved Hide resolved
browser_patches/webkit/archive.sh Show resolved Hide resolved
@aslushnikov
Copy link
Collaborator

@clopez awesome. Can you please re-baseline the PR? We'll land it and try rolling the fresh builds in to see how it works on our CI.

This patch changes the build system to use the JHBuild minimal dependency
system introduced in WebKit r264092 <https://trac.webkit.org/r264092>

The build has been tested with Ubuntu-18.04

The binary size of the zip bundles is now: 37M (WPE) and 40M (GTK).
Previously it was 54M and 59M (respectively)
@clopez
Copy link
Contributor Author

clopez commented Jul 9, 2020

@clopez awesome. Can you please re-baseline the PR? We'll land it and try rolling the fresh builds in to see how it works on our CI.

@aslushnikov: done.. i have rebased, and force pushed it.

@@ -1,3 +1,3 @@
REMOTE_URL="https://github.com/webkit/webkit"
BASE_BRANCH="master"
BASE_REVISION="19d11039faa6e4da8cf7487e9c54a00a7c6e18e2"
BASE_REVISION="822da5711ad337e1a7da82e813aa99e14fb79e49"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an intended change? Yury rolled webkit recently, so there should be no need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is intended. 19d11039faa6e4da8cf7487e9c54a00a7c6e18e2 is webkit r264022, but for this patch we need at least webkit r264092 (which its like 70 commits ahead). Here I used a commit a bit later than that: 822da5711ad337e1a7da82e813aa99e14fb79e49 (r264108) which was the last commit i could assert yesterday it was passing fine at the build.webkit.org CI

@aslushnikov aslushnikov merged commit cb8b1bc into microsoft:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants