Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(firefox): basic screencast implementation for GTK #2818

Merged
merged 1 commit into from
Jul 2, 2020
Merged

browser(firefox): basic screencast implementation for GTK #2818

merged 1 commit into from
Jul 2, 2020

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jul 2, 2020 •
edited
Loading

@yury-s yury-s force-pushed the ff-screencast-gtk-basic branch from 93b0bbb to e4e9997 Compare July 2, 2020 16:25
pavelfeldman
pavelfeldman approved these changes Jul 2, 2020
View reviewed changes
browser_patches/firefox/juggler/protocol/PageHandler.js Outdated
}

stopVideoRecording() {
if (!this._videoSessionId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== -1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yury-s yury-s force-pushed the ff-screencast-gtk-basic branch from e4e9997 to bde3ba1 Compare July 2, 2020 16:56
@yury-s yury-s merged commit 024cb1d into microsoft:master Jul 2, 2020
@yury-s yury-s deleted the ff-screencast-gtk-basic branch July 2, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @pavelfeldman