Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove Promise.all from examples #19154

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Nov 30, 2022

Replaced with explicit popupPromise variable.

@dgozman dgozman merged commit 4993249 into microsoft:main Nov 30, 2022
@brantphoto
Copy link

Hi all, any context or links to why Promise.all example was removed from download example? I know this is an old PR so my apologies. Thanks.

@mxschmitt
Copy link
Member

Hi all, any context or links to why Promise.all example was removed from download example? I know this is an old PR so my apologies. Thanks.

We learned that customers often use them incorrectly, by adding e.g. an await inside the Promise array. Having it the new way is essentially the same and simpler to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants