feat: send SIGTERM to webserver before SIGKILL'ing it. #18220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Oct 20, 2022
We now will send `SIGTERM` to the webserver and wait for the `timeout` before sending `SIGKILL` to it. Fixes microsoft#18209
aslushnikov
force-pushed
the
sigterm-webserver-before-sigkill
branch
from
c81c214 to
fe21e60
Compare
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Nov 4, 2022
…soft#18220)" This reverts commit c63a0b5.
aslushnikov
added a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now will send
SIGTERMto the webserver and wait for thetimeoutbefore sending
SIGKILLto it.Fixes #18209