Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(#12877): chore: print error if install-deps is used != ubuntu #13536

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

aslushnikov
Copy link
Collaborator

Reason: turns out Debian Buster requires just one source list to
install ttf-ubuntu-font-family font.

All other dependencies are satisfied.

Fixes #13530

…= ubuntu

Reason: turns out Debian Buster requires just one source list to
install `ttf-ubuntu-font-family` font.

All other dependencies are satisfied.

Fixes microsoft#13530
Copy link
Member

@rwoll rwoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it's verified to work (unofficially) on Debian, LGTM

@aslushnikov aslushnikov merged commit 269716d into microsoft:main Apr 13, 2022
@aslushnikov aslushnikov deleted the revert-ubuntu-restriction branch April 13, 2022 18:03
aslushnikov added a commit to aslushnikov/playwright that referenced this pull request Apr 13, 2022
…eps is used != ubuntu

Reason: turns out Debian Buster requires just one source list to
install `ttf-ubuntu-font-family` font.

All other dependencies are satisfied.

Fixes microsoft#13530
aslushnikov added a commit that referenced this pull request Apr 18, 2022
…ed != ubuntu (#13539)

Reason: turns out Debian Buster requires just one source list to
install `ttf-ubuntu-font-family` font.

All other dependencies are satisfied.

Fixes #13530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION]: Pull request #12877 prevents the library from being used on any linux distro that is not Ubuntu
2 participants