Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waitForPopup #17

Closed
JoelEinbinder opened this issue Nov 19, 2019 · 3 comments
Closed

waitForPopup #17

JoelEinbinder opened this issue Nov 19, 2019 · 3 comments
Assignees
@JoelEinbinder

Comments

@JoelEinbinder
Copy link
Contributor

No description provided.

@JoelEinbinder JoelEinbinder self-assigned this Nov 19, 2019
@JoelEinbinder
Copy link
Contributor Author

This gets tricky with whether waitForPopup should return only new popups, or query existing ones.
Dmitry needs the former. waitForNextPopup seems like a more explicit way of naming this. We may want to change browser.waitForTarget to be getOrWaitForTarget. We may also want to extend all of our event emitters with a fancy oncePromise method.

@dgozman
Copy link
Contributor

dgozman commented Dec 19, 2019

Generic waitForEvent now works for this thanks to #278. However, there is still a question whether we should only report popups after the first navigation is done, or provide some way to wait for it.

@dgozman
Copy link
Contributor

dgozman commented Jan 8, 2020

We now have popup.waitForLoadState which solves the first navigation issue.

@dgozman dgozman closed this as completed Jan 8, 2020
@yury-s yury-s mentioned this issue Mar 19, 2020
Closed
@dialupdev dialupdev mentioned this issue Apr 24, 2020
Closed
@yury-s yury-s mentioned this issue Apr 27, 2020
Closed
@rat-matheson rat-matheson mentioned this issue Jun 2, 2020
Closed
@yury-s yury-s mentioned this issue Jun 11, 2020
Merged
@yury-s yury-s mentioned this issue Jul 6, 2020
Merged
@pavelfeldman pavelfeldman mentioned this issue Jun 28, 2021
Closed
@sureshahead sureshahead mentioned this issue Sep 22, 2021
Closed
@Scuurpro Scuurpro mentioned this issue Feb 15, 2022
Closed
@yury-s yury-s mentioned this issue Mar 30, 2022
Closed
@rr13k rr13k mentioned this issue Apr 15, 2022
Closed
@Gopala7721 Gopala7721 mentioned this issue Jul 21, 2022
Closed
@madanankurmalviya madanankurmalviya mentioned this issue Aug 22, 2022
Closed
sand4rt pushed a commit to sand4rt/playwright that referenced this issue Dec 21, 2022
@arjunattam
fix: touch target size (microsoft#17)
42d504c
@CoderWinter121 CoderWinter121 mentioned this issue Jun 11, 2023
Closed
@Dolov Dolov mentioned this issue Oct 24, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoelEinbinder JoelEinbinder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoelEinbinder @dgozman