fix: report hash in page.url()

Fixes #2247
microsoft · May 14, 2020 · b65de33 · b65de33
1 parent f743cd9
commit b65de33
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/chromium/crPage.ts b/src/chromium/crPage.ts
@@ -500,7 +500,7 @@ class FrameSession {
   }
 
   _onFrameNavigated(framePayload: Protocol.Page.Frame, initial: boolean) {
-    this._page._frameManager.frameCommittedNewDocumentNavigation(framePayload.id, framePayload.url, framePayload.name || '', framePayload.loaderId, initial);
+    this._page._frameManager.frameCommittedNewDocumentNavigation(framePayload.id, framePayload.url + (framePayload.urlFragment || ''), framePayload.name || '', framePayload.loaderId, initial);
     if (!initial)
       this._firstNonInitialNavigationCommittedFulfill();
   }

diff --git a/test/page.spec.js b/test/page.spec.js
@@ -780,6 +780,14 @@ describe('Page.url', function() {
     await page.goto(server.EMPTY_PAGE);
     expect(page.url()).toBe(server.EMPTY_PAGE);
   });
+  it('should not return hashes', async({page, server}) => {
+    await page.goto(server.EMPTY_PAGE + '#hash');
+    expect(page.url()).toBe(server.EMPTY_PAGE + '#hash');
+    await page.evaluate(() => {
+      window.location.hash = "dynamic";
+    });
+    expect(page.url()).toBe(server.EMPTY_PAGE + '#dynamic');
+  });
 });
 
 describe('Page.title', function() {