fix(rpc): Frame.dblclick is missing notWaitAfter (#3210)

microsoft · Jul 29, 2020 · 84a17f2 · 84a17f2
1 parent 77b1c4b
commit 84a17f2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/src/rpc/channels.ts b/src/rpc/channels.ts
@@ -924,6 +924,7 @@ export type FrameContentResult = {
 export type FrameDblclickParams = {
   selector: string,
   force?: boolean,
+  noWaitAfter?: boolean,
   modifiers?: ('Alt' | 'Control' | 'Meta' | 'Shift')[],
   position?: {
     x: number,

diff --git a/src/rpc/protocol.yml b/src/rpc/protocol.yml
@@ -1049,6 +1049,7 @@ Frame:
       parameters:
         selector: string
         force: boolean?
+        noWaitAfter: boolean?
         modifiers:
           type: array?
           items:

diff --git a/src/rpc/validator.ts b/src/rpc/validator.ts
@@ -498,6 +498,7 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
   scheme.FrameDblclickParams = tObject({
     selector: tString,
     force: tOptional(tBoolean),
+    noWaitAfter: tOptional(tBoolean),
     modifiers: tOptional(tArray(tEnum(['Alt', 'Control', 'Meta', 'Shift']))),
     position: tOptional(tObject({
       x: tNumber,

diff --git a/test/autowaiting.jest.js b/test/autowaiting.jest.js
@@ -154,6 +154,11 @@ describe('Auto waiting', () => {
     await page.setContent(`<a href="${server.EMPTY_PAGE}">empty.html</a>`);
     await page.click('a', { noWaitAfter: true });
   });
+  it('should work with dblclick noWaitAfter: true', async({page, server}) => {
+    server.setRoute('/empty.html', async () => {});
+    await page.setContent(`<a href="${server.EMPTY_PAGE}">empty.html</a>`);
+    await page.dblclick('a', { noWaitAfter: true });
+  });
   it('should work with waitForLoadState(load)', async({page, server}) => {
     const messages = [];
     server.setRoute('/empty.html', async (req, res) => {