chore: add quotes to the path only when necessary (#29057)

This is a follow-up to c76f529 Reference #29039
microsoft · Jan 19, 2024 · 674988c · 674988c
1 parent 6a15d43
commit 674988c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/playwright/src/reporters/base.ts b/packages/playwright/src/reporters/base.ts
@@ -331,7 +331,7 @@ export function formatFailure(config: FullConfig, test: TestCase, options: {inde
             const packageManagerCommand = getPackageManagerExecCommand();
             resultLines.push(colors.cyan(`    Usage:`));
             resultLines.push('');
-            resultLines.push(colors.cyan(`        ${packageManagerCommand} playwright show-trace "${relativePath}"`));
+            resultLines.push(colors.cyan(`        ${packageManagerCommand} playwright show-trace ${quotePathIfNeeded(relativePath)}`));
             resultLines.push('');
           }
         } else {
@@ -373,6 +373,12 @@ export function formatFailure(config: FullConfig, test: TestCase, options: {inde
   };
 }
 
+function quotePathIfNeeded(path: string): string {
+  if (/\W/.test(path))
+    return `"${path}"`;
+  return path;
+}
+
 export function formatResultFailure(test: TestCase, result: TestResult, initialIndent: string, highlightCode: boolean): ErrorDetails[] {
   const errorDetails: ErrorDetails[] = [];