Skip to content

Commit

Permalink
chore: remove fake error from expect calls (#28112)
Browse files Browse the repository at this point in the history
We used to have a fake `error` property, so that trace viewer shows
failed expectes as such. Today, we have a step for each expect that
contains a proper error. Sending the fake error to the client confuses
language ports.
  • Loading branch information
dgozman authored Nov 14, 2023
1 parent ec4893d commit 2c3955a
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,6 @@ export class FrameDispatcher extends Dispatcher<Frame, channels.FrameChannel, Br
const result = await this._frame.expect(metadata, params.selector, { ...params, expectedValue });
if (result.received !== undefined)
result.received = serializeResult(result.received);
if (result.matches === params.isNot)
metadata.error = { error: { name: 'Expect', message: 'Expect failed' } };
return result;
}
}

0 comments on commit 2c3955a

Please sign in to comment.