fix(webkit): make click work with cross-process _blank target (#2083)

microsoft · May 2, 2020 · 03ca297 · 03ca297
1 parent f2fcb2b
commit 03ca297
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/webkit/wkPage.ts b/src/webkit/wkPage.ts
@@ -257,8 +257,8 @@ export class WKPage implements PageDelegate {
     });
     assert(targetInfo.type === 'page', 'Only page targets are expected in WebKit, received: ' + targetInfo.type);
 
-    if (!this._initializedPage) {
-      assert(!targetInfo.isProvisional);
+    if (!targetInfo.isProvisional) {
+      assert(!this._initializedPage);
       let pageOrError: Page | Error;
       try {
         this._setSession(session);

diff --git a/test/navigation.spec.js b/test/navigation.spec.js
@@ -994,7 +994,7 @@ describe('Click navigation', function() {
     await page.goto(server.EMPTY_PAGE);
     await page.click('"Click me"');
   });
-  it.fail(WEBKIT)('should work with cross-process _blank target', async({page, server}) => {
+  it('should work with cross-process _blank target', async({page, server}) => {
     server.setRoute('/empty.html', (req, res) => {
       res.end(`<a href="${server.CROSS_PROCESS_PREFIX}/empty.html" target="_blank">Click me</a>`);
     });