Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove development azurite keys #235

Merged
merged 13 commits into from
Aug 13, 2024
Merged

Conversation

joshimai
Copy link
Contributor

@joshimai joshimai commented Aug 1, 2024

Description

Update on 8/12/2024: replace docker-compose with docker compose because GitHub action runner has migrated to v2. Check out this post. Besides, I fixed the issues so it could pass the validation.

Remove the explicit strings for development keys and make them local env variables.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested locally /scripts/test

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Documentation has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@joshimai
Copy link
Contributor Author

joshimai commented Aug 1, 2024

Validate is failing on main as well. image

@elayrocks elayrocks force-pushed the user/joshi/remove-development-keys branch from a6f6191 to 568a5b7 Compare August 12, 2024 22:01
@elayrocks elayrocks requested a review from ghidalgo3 August 13, 2024 00:24
@srijan55
Copy link
Contributor

LGTM

@elayrocks elayrocks merged commit 822f8f5 into main Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants