Fix Crossgen symbol lookup. #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crossgened DLLs might be named XXX.dd rather than XXX.ni.dll. However the Native PDBs for these are always XXX.ni.pdb. Previously we used the DLL name to make the PDB name, now we use the emedded PDB name (which is always right).
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 24.35% 24.35%
=======================================
Files 199 199
Lines 112479 112479
Branches 11228 11228
=======================================
Hits 27397 27397
Misses 85055 85055
Partials 27 27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 24.35% 24.35%
=======================================
Files 199 199
Lines 112479 112479
Branches 11228 11228
=======================================
Hits 27397 27397
Misses 85055 85055
Partials 27 27
Continue to review full report at Codecov.
|
vancem
added a commit
to vancem/perfview
that referenced
this pull request
Dec 20, 2017
Fix Crossgen symbol lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossgened DLLs might be named XXX.dd rather than XXX.ni.dll.
However the Native PDBs for these are always XXX.ni.pdb. Previously
we used the DLL name to make the PDB name, now we use the
emedded PDB name (which is always right).