Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HistoryDictionary: Replace manually sorted list with SortedDictionary #298

Merged
merged 1 commit into from
Jul 12, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/TraceEvent/TraceUtilities/HistoryDictionary.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,20 @@ public void Add(Address id, long startTime, T value, bool isEndRundown = false)

// See if we can jump ahead. Currently we only do this of the first entry,
// But you could imagine using some of the other nodes's skipAhead entries.
if (firstEntry.skipAhead != null && firstEntry.skipAhead.startTime < startTime)
if (firstEntry.skipAhead != null && firstEntry.skipAhead.startTime <= startTime)
entry = firstEntry.skipAhead;

for (; ; )
{
// We found exact match
if (startTime == entry.StartTime)
{
// Just update the value and exit immediately as there is no need to
// update skipAhead or increment count
entry.value = value;
return;
}

if (entry.next == null)
{
entry.next = new HistoryValue(startTime, id, value);
Expand Down