Include Microsoft.Diagnostics.FastSerialization in the TraceEvent package #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Microsoft.Diagnostics.Tracing.TraceEvent assembly depends on Microsoft.Diagnostics.FastSerialization, but no dependency was added to the NuGet package. Rather than deal with separate NuGet packages at this time, this change simply includes the dependency in the original NuGet package.
📝 If we ever need to split these in the future, we can trivially do so and add a dependency from the current NuGet package to the new one without breaking upgrade scenarios. Since this makes distribution a little bit more complex (managing multiple NuGet releases from one repository) and didn't seem essential at this time, I chose the simplest route to packaging for my initial proposed approach.