Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Symweb Authentication to PerfView #2039

Merged
merged 3 commits into from
May 30, 2024

Conversation

brianrob
Copy link
Member

  • Add support for authentication to Symweb.
  • Add missing dependencies that previously broke existing ADO authentication and are also needed for Symweb.
  • Increase timeout for downloads.
  • Tell HttpClient.GetAsync to return immediately after the response headers have been downloaded. This allows SymbolReader to show download progress and not timeout for larger symbol files.

Fix loading of dependencies for authentication and add special handling
for symweb.
@brianrob brianrob requested a review from pharring May 27, 2024 01:01
@brianrob brianrob changed the title Add Support for Symweb Authentication Add Support for Symweb Authentication to PerfView May 27, 2024
cincuranet
cincuranet previously approved these changes May 28, 2024
@brianrob brianrob enabled auto-merge (squash) May 30, 2024 00:17
@brianrob brianrob merged commit c805b11 into microsoft:main May 30, 2024
5 checks passed
@brianrob brianrob deleted the dev/brianrob/symweb-auth branch May 30, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants