Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Concatenate SSH command for user #4250

Merged
merged 11 commits into from
Mar 10, 2020
Merged

Concatenate SSH command for user #4250

merged 11 commits into from
Mar 10, 2020

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Mar 4, 2020

If the container has a "ssh" port, concatenate the SSH information for better user experience

image

image

@hzy46 hzy46 requested review from mydmdm and debuggy March 4, 2020 08:44
@hzy46 hzy46 mentioned this pull request Mar 4, 2020
Closed
74 tasks
@hzy46 hzy46 merged commit b1212e9 into master Mar 10, 2020
@hzy46
Copy link
Contributor Author

hzy46 commented Apr 20, 2020 •
edited
Loading

Test cases:

  1. submit an SSH-enabled job; click View SSH Info on job detail page; make sure the command is usable

  2. submit an SSH-disabled job; click View SSH Info on job detail page; make sure the command reminds you to enable SSH

@hzy46 hzy46 mentioned this pull request Apr 20, 2020
Closed
36 tasks
@debuggy debuggy mentioned this pull request Apr 23, 2020
Closed
11 tasks
@hzy46 hzy46 deleted the zhiyuhe/fix_ssh_info branch July 17, 2020 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abuccts abuccts abuccts approved these changes

@mydmdm mydmdm Awaiting requested review from mydmdm

@debuggy debuggy Awaiting requested review from debuggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzy46 @abuccts