Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Fix version change in webportal #3591

Closed
wants to merge 2 commits into from
Closed

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Sep 9, 2019

Currently we use cp -arf "../../../version" "../version" to copy the PAI version to src/webportal/ , here is a small problem:

  • If it is the first time to run cp -arf "../../../version" "../version" , a version folder will be created under src/webportal
  • If you run the cp -arf "../../../version" "../version" again, it will copy the version folder under src/webportal/version/. Thus the folder structure becomes src/webportal/version/version, which is not desired.

To reproduce:

  • build and deploy the cluster
  • change the PAI.VERSION to make a new version
  • build and deploy the cluster, but the version will not change in webportal

@debuggy
Copy link
Contributor

debuggy commented Sep 9, 2019

Why would this cp command run two times?

@hzy46
Copy link
Contributor Author

hzy46 commented Sep 9, 2019

Why would this cp command run two times?

For example, I built and deployed the cluster on 2pm. After some code changes, I built it again on 3pm using the same directory. Then this problem would occur.

@debuggy
Copy link
Contributor

debuggy commented Sep 9, 2019

Why would this cp command run two times?

For example, I built and deployed the cluster on 2pm. After some code changes, I built it again on 3pm using the same directory. Then this problem would occur.

ok, I got it.

@hzy46
Copy link
Contributor Author

hzy46 commented Oct 15, 2019

The way in the script to make a "version" folder conflicts with the Jenkins pipeline. Close this PR to find a better fix or modify the Jenkins file.

@hzy46 hzy46 closed this Oct 15, 2019
@hzy46 hzy46 deleted the zhiyuhe/fix_webportal_version branch December 25, 2019 07:17
@hzy46 hzy46 restored the zhiyuhe/fix_webportal_version branch December 25, 2019 07:17
@hzy46 hzy46 deleted the zhiyuhe/fix_webportal_version branch October 5, 2020 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants