-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ops(max_pool3d and max_pool3d_with_indices) | feat(atenlib) #618
Conversation
fatcat-z
commented
Apr 11, 2023
- Add max_pool3d and max_pool3d_with_indices ops.
- Refactor the code so max_pool2d and max_pool3d could share the same helper function. And move them to nn.py file.
- Refactor the code so max_pool2d_with_indices and max_pool3d_indices could share the same helper function. And move them to nn.py file.
- Add tests.
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 74.49% 74.54% +0.04%
==========================================
Files 107 107
Lines 11305 11302 -3
Branches 1182 1177 -5
==========================================
+ Hits 8422 8425 +3
+ Misses 2561 2557 -4
+ Partials 322 320 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
# So indices results to the expected output which is : | ||
# [[0,1], | ||
# [0,1]] | ||
# For more information : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! This makes a lot of sense
"nn.functional.max_pool3d", | ||
matcher=lambda sample: sample.kwargs.get("ceil_mode") is True | ||
and sample.kwargs.get("padding") == 1, | ||
reason="this combinations is not supported.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it not supported or was there a bug?
reason="this combinations is not supported.", | |
reason="fixme: (what we reported in ORT)", |
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Justin Chu <[email protected]>