[WebNN] Improve data type check of slice op #22988
Open
+138
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Honry PTAL, thanks! |
Honry
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Thanks @shiyi9801, data type check is not rigorous in WebNN EP, especially for those ONNX ops that need to be supported by decomposed WebNN ops. This is a good starting.👍
| if (!ReadIntArrayFrom1DTensor(*initializers.at(input_defs[4]->Name()), steps, logger)) | ||
| return false; | ||
| if (std::any_of(steps.begin(), steps.end(), [](int64_t step) { return step < 0; })) { | ||
| if (!IsDataTypeSupportedByWebNNOp(op_type, "reverse", input_type, wnn_limits, "input", "data", logger)) { |
There was a problem hiding this comment.
Maybe we can simplify this by using a parameter webnn_op_type, set it to reverse or slice according to the step value.
Then only call IsDataTypeSupportedByWebNNOp once.
There was a problem hiding this comment.
slice always needs to be checked (except for a few cases like steps=1, start=0, end=input_dim) so we still have to call IsDataTypeSupportedByWebNNOp() twice.
Co-authored-by: Wanming Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up of [WebNN] Support negative steps for slice. Slice op is emulated by reverse+slice when steps < 0 so
SliceOpBuilder::HasSupportedInputsImpl()should also check the supported data types of reverse.