Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebNN] Update usage of MLTensor to align with latest spec #22959

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Nov 27, 2024

Remove deprecated 'numThreads' option BTW.

Remove deprecated 'numThreads' option BTW.
@Honry
Copy link
Contributor Author

Honry commented Nov 27, 2024

@fdwr, @guschmue, PTAL, thanks!

cc// @ibelem

fdwr
fdwr previously approved these changes Dec 3, 2024
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

docs/tutorials/web/ep-webnn.md Outdated Show resolved Hide resolved
docs/tutorials/web/ep-webnn.md Outdated Show resolved Hide resolved
docs/tutorials/web/ep-webnn.md Outdated Show resolved Hide resolved
@fdwr
Copy link
Contributor

fdwr commented Dec 3, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Dec 3, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Dec 3, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Dec 3, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

3 similar comments
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Honry
Copy link
Contributor Author

Honry commented Dec 3, 2024

@fdwr, thank you for your review! Comments addressed, PTAL again, thanks!

Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Dec 3, 2024

Check for broken links
https://microsoft.github.io/Olive/features/cli.html failed: 404 No error

https://github.com/microsoft/onnxruntime/actions/runs/12133242537/job/33872573345?pr=22959

Never mind - it's on an unrelated page to your change "_site/docs/genai/tutorials/finetune.html".

@fdwr fdwr merged commit f840702 into microsoft:gh-pages Dec 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants