Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorRT EP] Use TRT/CUDA/ORT version from runtime instead of build time to generate hash value #22921

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

chilo-ms
Copy link
Contributor

@chilo-ms chilo-ms commented Nov 21, 2024

Use TensorRT and CUDA version fetched at runtime to get the hash value which determines the cache name.

The old way to get the version is at compile/build time that might have some issues in some cases,
ex:
TRT EP uses the TRT version which we or users built against at compile time.
However, users can change different TRT version at run time, that can cause issue because TRT EP always checks the "fixed" TRT version, not the TRT version it uses now. This can cause TRT EP to use incompatible TRT engine cache.

see the github issue here:
#22382 (comment)

Copy link
Contributor

@yf711 yf711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I've tested on FRCNN model and now hash values are different when promoting trt lib version.

@chilo-ms chilo-ms merged commit 9b9f881 into main Dec 4, 2024
95 checks passed
@chilo-ms chilo-ms deleted the chi/trt_ep_refactor branch December 4, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants