Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DML GPU pool in Windows GPU workflow use Visual Studio 2022 #16784

Merged
merged 2 commits into from
Jul 23, 2023

Conversation

mszhanyi
Copy link
Contributor

Description

  1. use the pool with VS2022
  2. upgrade System.Memory to 4.5.5

Motivation and Context

Solve the build error while using VS2022:
[Failure] Msbuild failed when processing the file 'D:\a\_work\1\s\csharp\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj' with message: Method not found: 'System.ReadOnlySpan1 Microsoft.IO.Path.GetFileName(System.ReadOnlySpan1<Char>)'

Ref: https://stackoverflow.com/questions/73399777/azure-build-failing-due-to-method-not-found-system-readonlyspan1char-micros

@mszhanyi mszhanyi requested a review from a team as a code owner July 21, 2023 03:28
@mszhanyi mszhanyi requested a review from yuslepukhin July 21, 2023 03:29
@mszhanyi mszhanyi merged commit 3252ff2 into main Jul 23, 2023
@mszhanyi mszhanyi deleted the zhanyi/dmlinortpool branch July 23, 2023 02:07
jchen351 pushed a commit that referenced this pull request Aug 12, 2023
…16784)

### Description
1. use the pool with VS2022
2. upgrade System.Memory to 4.5.5


### Motivation and Context
Solve the build error while using VS2022:
`[Failure] Msbuild failed when processing the file
'D:\a\_work\1\s\csharp\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj'
with message: Method not found: 'System.ReadOnlySpan`1<Char>
Microsoft.IO.Path.GetFileName(System.ReadOnlySpan`1<Char>)'`

Ref:
https://stackoverflow.com/questions/73399777/azure-build-failing-due-to-method-not-found-system-readonlyspan1char-micros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants