Add support for training apis to support custom ops #16601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
added
the
training
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| yield | ||
| finally: | ||
| _GLOBAL_CUSTOM_OP_LIBRARY = None |
Check notice
Code scanning / CodeQL
Unused global variable
pengwa
reviewed
Jul 10, 2023
pengwa
reviewed
Jul 10, 2023
pengwa
reviewed
Jul 10, 2023
orttraining/orttraining/python/training/onnxblock/_training_graph_utils.py
Show resolved
Hide resolved
…baijumeswani/training-artifacts-with-custom-ops
One of our partner teams has a need for the op This pull request allows for us to register any user provided custom op library (such as |
…baijumeswani/training-artifacts-with-custom-ops
…baijumeswani/training-artifacts-with-custom-ops
pengwa
reviewed
Jul 11, 2023
askhade
reviewed
Jul 11, 2023
…baijumeswani/training-artifacts-with-custom-ops
pengwa
previously approved these changes
Jul 14, 2023
Co-authored-by: pengwa <[email protected]>
pengwa
approved these changes
Jul 14, 2023
baijumeswani
added a commit
that referenced
this pull request
Jul 21, 2023
This pull request contains a few changes: 1. Adds support for string ort values. 2. Fixes the training minimal build (that was broken with #16601) by putting custom op registration behind #ifdefs 3. Fixes the iOS pod package generation (that was again broken with #16601) by explicitly providing paths to be copied during pod creation.
jchen351
pushed a commit
that referenced
this pull request
Aug 12, 2023
This pull request contains a few changes: 1. Adds support for string ort values. 2. Fixes the training minimal build (that was broken with #16601) by putting custom op registration behind #ifdefs 3. Fixes the iOS pod package generation (that was again broken with #16601) by explicitly providing paths to be copied during pod creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the training API did not include support to register custom op libraries.
One of the models we are working with requires the use of
onnxruntime-extensions.onnxruntime-extensionsis implemented as a custom op and needs to be registered withONNX Runtimebefore an ONNX model containing the custom op nodes can be executed.This pull request adds the necessary tooling to register the custom op library for both, artifact generation, and graph execution.
In addition, this pull request also adds support for executing models with string tensor inputs.