-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiling Rust bindings #14884
base: main
Are you sure you want to change the base?
Compiling Rust bindings #14884
Conversation
@microsoft-github-policy-service agree company="RoboHouse" |
@hgaiser Thanks for this contribution. So the built packages that I have looked at for 1.14.0 and 1.14.1 have |
I don't think it's that simple, right? Any idea why the compiled version has these paths, but the downloaded one does not? |
Description
The current value of VERSION_NUMBER is 1.15.0, but this isn't released yet. The Rust bindings use this version to decide what compiled package to download. Seeing as 1.15.0 isn't yet released, this fails to download. Downloading 1.14.0 works, but there's no way to override this behavior from other crates. Adding an option to set the version number using an environment variable gives more freedom in choosing the onnxruntime version.
In addition I experienced that including the version number also added a newline character at the end, which makes the path it generates invalid. To fix this I trimmed the version number, to remove any whitespaces (including newlines).
Lastly, the generated include dir didn't exist for me, so I corrected it to point to the include dir that did exist. I'm not sure what's going wrong here?
Motivation and Context
I wasn't able to use the Rust bindings in my crate. With these fixes I can use it.
Pinging @boydjohnson since I believe he was the main person working on moving the binding into this repository.