Remove the cmake option: onnxruntime_DEV_MODE #13573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
commented
Nov 5, 2022
| #else | ||
| -#if defined(_MSC_VER) && !defined(__INTEL_COMPILER) | ||
| +#if defined(_MSC_VER) && !defined(__INTEL_COMPILER) && !defined(__NVCC__) | ||
| #define GSL_SUPPRESS(x) [[gsl::suppress(x)]] |
There was a problem hiding this comment.
nvcc doesn't recognize this "gsl" attribute namespace.
There was a problem hiding this comment.
Hi! I see how onnxruntime is probably the only GSL user to build it with nvcc, but on the other hand the patch is fairly small. Have you considered upstreaming it?
jywu-msft
approved these changes
Nov 7, 2022
henrywu2019
pushed a commit
to henrywu2019/onnxruntime
that referenced
this pull request
Dec 21, 2022
1. Remove the cmake option onnxruntime_DEV_MODE and replace it with "--compile-no-warning-as-error" 2. Suppress some GSL warnings because now we treat nvcc diag warnings as errors
12 tasks
| URL https://github.com/microsoft/GSL/archive/refs/tags/v4.0.0.zip | ||
| URL_HASH SHA1=cf368104cd22a87b4dd0c80228919bb2df3e2a14 | ||
| ) | ||
| endif() |
There was a problem hiding this comment.
Correct me if I'm wrong, but the patch is safe to apply even when building with CUDA support turned off? What do you think about applying it unconditionally instead, so that both cuda-ful and cuda-free builds are built from "identical" source code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context