Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust bindings #12606
Add rust bindings #12606
Changes from all commits
3845ab5
e7372ab
a9e7b1e
75f2d12
365a37f
2788a24
775e76e
cb2dfbe
fc69d37
7a9809e
10ef1f2
4218e65
0ce7756
4896963
04857ed
e3b9b60
5dc5478
522c7d8
b98fc3d
7bad5a3
57cc343
836ffc9
0027024
fe4000a
4d6acfc
656b3dc
fc5c080
05c9af2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, *_PATH made me think folder vs the actual filename. Since it should always be called 'onnxruntime.dll' I didn't think to give the name of the library itself.
Up to you if you think it should let you override the library filename, since it does make the path more platform specific. But I'd recommend adding an example just so remove all doubt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another idea, as you mentioned running 'cargo c' and seeing where it goes, could this process set the environment variable to where it was put if the variable isn't already set? Or is that a bad idea?
Ideally it'd "just work", but it's up to you. This would work across all OS's hopefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added libonnxruntime.so as an example.