ORT 1.19 Release: Cherry-Pick Round 1 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update macosx framework packaging to follow apple guidelines * Test path fix * Update tools/ci_build/extract_nuget_files.ps1 ---------
prathikr
changed the title
skottmckay
reviewed
Aug 13, 2024
| @@ -77,12 +74,12 @@ def do_build_by_mode( | |||
|
|
|||
| jnilib_names = ["libortextensions.so", "libonnxruntime_extensions4j_jni.so"] | |||
| for jnilib_name in jnilib_names: | |||
| shutil.copyfile(build_dir / config / "java" / "android" / abi / jnilib_name, jnilibs_dir / jnilib_name) | |||
| shutil.copyfile(build_dir / config / "lib" / jnilib_name, jnilibs_dir / jnilib_name) | |||
There was a problem hiding this comment.
No clear that we want this change to the path. Something changed in the main CI that required it (possibly the gradle version of the image being used to build but we haven't had time to figure out what it was), but the 0.19 branch was still passing without it.
could try with it first to keep the cherry pick clean and undo if needed.
skottmckay
approved these changes
Aug 13, 2024
vraspar
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick PRs for ORT 1.19 release