Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancellation support #15

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Add cancellation support #15

merged 6 commits into from
Nov 3, 2022

Conversation

Tarrowren
Copy link
Contributor

issue #10

@Tarrowren
Copy link
Contributor Author

@microsoft-github-policy-service agree

aeschli
aeschli requested changes Nov 2, 2022
View reviewed changes
package.json Show resolved Hide resolved
src/browser/main.ts Outdated Show resolved Hide resolved
@aeschli
Copy link
Contributor

aeschli commented Nov 2, 2022

Thanks a lot for the PR, @Tarrowren! See my comments...

@aeschli
Copy link
Contributor

aeschli commented Nov 3, 2022 •
edited
Loading

The problem is that the api.d.ts has a import("vscode-jsonrpc").CancellationToken;.
As vscode-jsonrpc is only a dev dependency that means that users of request-light wont get it, and the type can not be resolved.
I see we have the same problem with HttpProxyAgent and HttpsProxyAgent.

I think we should redefine the interfaces for CancellationToken (and Event and Disposable)

aeschli
aeschli previously approved these changes Nov 3, 2022
View reviewed changes
@aeschli aeschli added this to the November 2022 milestone Nov 3, 2022
@aeschli aeschli merged commit a4ae2b3 into microsoft:main Nov 3, 2022
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschli aeschli aeschli approved these changes

@dbaeumer dbaeumer dbaeumer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.
3 participants
@Tarrowren @aeschli @dbaeumer