Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against newer ConPTY's #714

Closed
cpendery opened this issue Sep 13, 2024 · 3 comments
Closed

Build against newer ConPTY's #714

cpendery opened this issue Sep 13, 2024 · 3 comments

Comments

@cpendery
Copy link
Member

Issue description

Right now, node-pty / conpty flushes osc sequences so they don't appear inline with the terminal text. According to microsoft/terminal#17313, this issue has been addressed and is targeted for Terminal v1.23 in November 2024 according to microsoft/terminal#17643. This would help with Git Bash support in VSCode, and I'd like to leverage it before it gets included in Windows 11 distributions (to avoid the gap between Terminal & Windows conPTY versions).

Is there a way node-pty can be built against a set version of conpty instead of the one bundled with Windows?

@cpendery cpendery changed the title Build against newer conPTY's Build against newer ConPTY's Sep 13, 2024
@cpendery
Copy link
Member Author

There is a thread from @DHowett here that describes how they are publishing NuGet versions of ConPTY along with its required OpenConsole.exe. Maybe we could leverage this @Tyriar?

@lydell
Copy link

lydell commented Sep 13, 2024

A bundled conpty was added here: #694

The maintainers of this repo have worked hard on making that feature stable since: https://github.com/microsoft/node-pty/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aclosed

Beta versions are automatically published when things are merged into main. At the time of this writing, the latest beta version is 1.1.0-beta21.

@cpendery
Copy link
Member Author

Closing and just tracking microsoft/vscode#224488 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants