Merge pull request #718 from microsoft/tyriar/717

Close piClient.hThread handle
microsoft · Oct 3, 2024 · b2d9866 · b2d9866
2 parents 1ece036 + d2bf81f
commit b2d9866
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/win/conpty.cc b/src/win/conpty.cc
@@ -429,6 +429,9 @@ static Napi::Value PtyConnect(const Napi::CallbackInfo& info) {
   // Update handle
   handle->hShell = piClient.hProcess;
 
+  // Close the thread handle to avoid resource leak
+  CloseHandle(piClient.hThread);
+
   SetupExitCallback(env, exitCallback, handle);
 
   // Return