Tested the PR. Add comment

microsoft · Aug 25, 2023 · 41ec9dc · 41ec9dc
1 parent 81de664
commit 41ec9dc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/win/conpty.cc b/src/win/conpty.cc
@@ -258,8 +258,9 @@ static void OnProcessExit(uv_async_t *async) {
   GetExitCodeProcess(baton->hShell, &exitCode);
 
   // Clean up handles
-  DisconnectNamedPipe(baton->hIn);
-  DisconnectNamedPipe(baton->hOut);
+  // Calling DisconnectNamedPipes here or in PtyKill results in a crash,
+  // ref https://github.com/microsoft/node-pty/issues/512,
+  // so we only call CloseHandle for now.
   CloseHandle(baton->hIn);
   CloseHandle(baton->hOut);