Fix subclass typedefs #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the subclass (
extends) information has been missing from the generated typedefs. Instead, subclasses included all inherited members, so the hierarchy was flattened. That could cause problems working with some APIs that depend on polymorphism. I'm pretty sure I did it that way because I had trouble getting subclasses to compile without errors originally, and just forgot to come back to it. There were some complexities related to overloads, extension methods, and base type references, which I've managed to resolve now.This also fixes marshalling of optional
AbortSignalto/fromCancellationTokenwhich I noticed while testing the semantic-kernel example.