Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE in source generator for methods with arrays #278

Merged
merged 1 commit into from
Apr 16, 2024

Fix NRE in source generator for methods with arrays

e8bbca1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix NRE in source generator for methods with arrays #278

Fix NRE in source generator for methods with arrays
e8bbca1
Select commit
Loading
Failed to load commit list.
GitHub Actions / test results (windows-latest, net8.0, node18.x, Release) succeeded Apr 16, 2024 in 0s

109 passed, 0 failed and 13 skipped

Tests passed successfully

✅ test/net8.0-node18.x-Release/runneradmin_fv-az663-211_2024-04-16_06_35_15.trx

122 tests were completed in 218s with 109 passed, 0 failed and 13 skipped.

Test suite Passed Failed Skipped Time
Microsoft.JavaScript.NodeApi.Test.GCTests 2⚪ 2ms
Microsoft.JavaScript.NodeApi.Test.HostedClrTests 32✅ 26s
Microsoft.JavaScript.NodeApi.Test.JSProjectTests 16✅ 157s
Microsoft.JavaScript.NodeApi.Test.JSReferenceTests 4✅ 7ms
Microsoft.JavaScript.NodeApi.Test.JSValueScopeTests 19✅ 12ms
Microsoft.JavaScript.NodeApi.Test.NativeAotTests 27✅ 28s
Microsoft.JavaScript.NodeApi.Test.NodejsEmbeddingTests 11⚪ 11ms
Microsoft.JavaScript.NodeApi.Test.TypeDefsGeneratorTests 11✅ 23ms

✅ Microsoft.JavaScript.NodeApi.Test.GCTests

⚪ GCHandles
⚪ GCObjects

✅ Microsoft.JavaScript.NodeApi.Test.HostedClrTests

✅ Test(id: "edgejs-perf/measure-latency")
✅ Test(id: "napi-dotnet-init/custom_export")
✅ Test(id: "napi-dotnet-init/custom_init")
✅ Test(id: "napi-dotnet/async_methods")
✅ Test(id: "napi-dotnet/complex_types")
✅ Test(id: "napi-dotnet/delegates")
✅ Test(id: "napi-dotnet/dynamic_extensions")
✅ Test(id: "napi-dotnet/dynamic_generics")
✅ Test(id: "napi-dotnet/dynamic_invoke")
✅ Test(id: "napi-dotnet/dynamic_no_namespace_type")
✅ Test(id: "napi-dotnet/dynamic_optional_params")
✅ Test(id: "napi-dotnet/errors")
✅ Test(id: "napi-dotnet/hello")
✅ Test(id: "napi-dotnet/module_class")
✅ Test(id: "napi-dotnet/multi_instance")
✅ Test(id: "napi-dotnet/overloads")
✅ Test(id: "napi-dotnet/streams")
✅ Test(id: "node-addon-api/basic_types/array")
✅ Test(id: "node-addon-api/basic_types/boolean")
✅ Test(id: "node-addon-api/basic_types/number")
✅ Test(id: "node-addon-api/basic_types/value")
✅ Test(id: "node-addon-api/bigint")
✅ Test(id: "node-addon-api/object/delete_property")
✅ Test(id: "node-addon-api/object/finalizer")
✅ Test(id: "node-addon-api/object/get_property")
✅ Test(id: "node-addon-api/object/has_own_property")
✅ Test(id: "node-addon-api/object/has_property")
✅ Test(id: "node-addon-api/object/object_freeze_seal")
✅ Test(id: "node-addon-api/object/object")
✅ Test(id: "node-addon-api/object/set_property")
✅ Test(id: "node-addon-api/object/subscript_operator")
✅ Test(id: "node-addon-api/testUtil")

✅ Microsoft.JavaScript.NodeApi.Test.JSProjectTests

✅ Test(id: "projects/js-cjs-dynamic/default")
✅ Test(id: "projects/js-cjs-dynamic/net8.0")
✅ Test(id: "projects/js-cjs-module/default")
✅ Test(id: "projects/js-cjs-module/net8.0")
✅ Test(id: "projects/js-esm-dynamic/default")
✅ Test(id: "projects/js-esm-dynamic/net8.0")
✅ Test(id: "projects/js-esm-module/default")
✅ Test(id: "projects/js-esm-module/net8.0")
✅ Test(id: "projects/ts-cjs-dynamic/default")
✅ Test(id: "projects/ts-cjs-dynamic/net8.0")
✅ Test(id: "projects/ts-cjs-module/default")
✅ Test(id: "projects/ts-cjs-module/net8.0")
✅ Test(id: "projects/ts-esm-dynamic/default")
✅ Test(id: "projects/ts-esm-dynamic/net8.0")
✅ Test(id: "projects/ts-esm-module/default")
✅ Test(id: "projects/ts-esm-module/net8.0")

✅ Microsoft.JavaScript.NodeApi.Test.JSReferenceTests

✅ GetReferenceFromDifferentRootScope
✅ GetReferenceFromDifferentThread
✅ GetReferenceFromParentScope
✅ GetReferenceFromSameScope

✅ Microsoft.JavaScript.NodeApi.Test.JSValueScopeTests

✅ AccessPropertyKeyFromClosedScope
✅ AccessValueFromClosedScope
✅ AccessValueFromDifferentRootScope
✅ AccessValueFromDifferentThread
✅ CreateCallbackScope
✅ CreateEscapableScopeWithinCallback
✅ CreateHandleScopeWithinCallback
✅ CreateHandleScopeWithinModule
✅ CreateHandleScopeWithinRoot
✅ CreateModuleScopeWithinNoContextScope
✅ CreateModuleScopeWithinRootScope
✅ CreateModuleScopeWithoutRoot
✅ CreateNoContextScope
✅ CreateRootScope
✅ CreateValueFromDifferentThread
✅ InvalidCallbackContextScopeNesting
✅ InvalidModuleContextScopeNesting
✅ InvalidNoContextScopeNesting
✅ InvalidRootContextScopeNesting

✅ Microsoft.JavaScript.NodeApi.Test.NativeAotTests

✅ Test(id: "edgejs-perf/measure-latency")
✅ Test(id: "napi-dotnet-init/custom_export")
✅ Test(id: "napi-dotnet-init/custom_init")
✅ Test(id: "napi-dotnet/async_methods")
✅ Test(id: "napi-dotnet/complex_types")
✅ Test(id: "napi-dotnet/delegates")
✅ Test(id: "napi-dotnet/errors")
✅ Test(id: "napi-dotnet/hello")
✅ Test(id: "napi-dotnet/module_class")
✅ Test(id: "napi-dotnet/multi_instance")
✅ Test(id: "napi-dotnet/overloads")
✅ Test(id: "napi-dotnet/streams")
✅ Test(id: "node-addon-api/basic_types/array")
✅ Test(id: "node-addon-api/basic_types/boolean")
✅ Test(id: "node-addon-api/basic_types/number")
✅ Test(id: "node-addon-api/basic_types/value")
✅ Test(id: "node-addon-api/bigint")
✅ Test(id: "node-addon-api/object/delete_property")
✅ Test(id: "node-addon-api/object/finalizer")
✅ Test(id: "node-addon-api/object/get_property")
✅ Test(id: "node-addon-api/object/has_own_property")
✅ Test(id: "node-addon-api/object/has_property")
✅ Test(id: "node-addon-api/object/object_freeze_seal")
✅ Test(id: "node-addon-api/object/object")
✅ Test(id: "node-addon-api/object/set_property")
✅ Test(id: "node-addon-api/object/subscript_operator")
✅ Test(id: "node-addon-api/testUtil")

✅ Microsoft.JavaScript.NodeApi.Test.NodejsEmbeddingTests

⚪ CallFunction
⚪ ErrorPropagation
⚪ ImportBuiltinModule
⚪ ImportCommonJSModule
⚪ ImportCommonJSPackage
⚪ ImportESModule
⚪ ImportESPackage
⚪ MarshalClass
⚪ RestartEnvironment
⚪ StartEnvironment
⚪ UnhandledRejection

✅ Microsoft.JavaScript.NodeApi.Test.TypeDefsGeneratorTests

✅ GenerateEnum
✅ GenerateExtensionMethods
✅ GenerateGenericClass
✅ GenerateGenericDelegate
✅ GenerateGenericInterface
✅ GenerateJSDocLink
✅ GenerateSimpleClass
✅ GenerateSimpleDelegate
✅ GenerateSimpleInterface
✅ GenerateSimpleMethod
✅ GenerateSimpleProperty