Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors due to indexers #273

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix build errors due to indexers #273

merged 1 commit into from
Apr 12, 2024

Conversation

jasongin
Copy link
Member

Fixes: #270
Fixes: #271

  • Exclude indexers from module exports for now, with a warning.
  • Fix a couple things which are not really needed as long as indexers aren't exported by the module generator, but might be helpful in the future:
    • Handle indexer properties when converting expression trees to C# code.
    • Handle multiple indexers on one class when converting type symbols to types.

JavaScript doesn't support C# style indexers. (Technically it could with proxies, but I don't think we want to make every .NET object a proxy.) We could do something else like generate get/set methods for the indexer, but that would be more work. For now it's a good improvement that at least indexers won't break the build.

@jasongin jasongin merged commit f3f5b2e into main Apr 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants