-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement strongly typed cast from/to JSValue #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongin
reviewed
Feb 2, 2024
vmoroz
force-pushed
the
PR/object_type_cast
branch
from
August 2, 2024 18:53
ee71872
to
5c4e176
Compare
vmoroz
changed the title
[DRAFT] Implement strongly typed case from/to JSValue
Implement strongly typed case from/to JSValue
Aug 5, 2024
vmoroz
changed the title
Implement strongly typed case from/to JSValue
Implement strongly typed cast from/to JSValue
Aug 5, 2024
jasongin
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements checked and unchecked casting between
JSValue
and other types that implement the newIJSValue
interface.IJSValue
interface which is implemented byJSValue
and types that wrap upJSValue
such asJSArray
,JSDate
, etc.IJSValue
interface new generic methods:Is<T>
,As<T>
,AsUnchecked<T>
, andCastTo<T>
.IJSValue
static methodsCanCreateFrom
andCreateUnchecked
. In case if we targeted .Net version is below version 7.0, it usesIJSValueShim
helper class that binds to static methods using reflection.IJSValue
derived types implement these casting instance methods and the helper static methods.JSValue.As<T>
method.Please note that I could not find a good way to differentiate
Proxy
fromObject
and currently anyJSValue
that is an object can be casted toJSProxy
.