-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping between .Net objects and JSReference should not allow to match objects of different types. #156
Closed
Closed
Mapping between .Net objects and JSReference should not allow to match objects of different types. #156
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT License. | ||
|
||
using System.Collections.Generic; | ||
|
||
namespace Microsoft.JavaScript.NodeApi.Interop; | ||
|
||
/// <summary> | ||
/// Default .Net to JS objects translation equality comparer. | ||
/// </summary> | ||
public class JSTranslationEqualityComparer : IEqualityComparer<object> | ||
{ | ||
/// <summary> | ||
/// Single instance of the comparer. | ||
/// </summary> | ||
public static JSTranslationEqualityComparer Instance { get; } = new (); | ||
|
||
private JSTranslationEqualityComparer() | ||
{ | ||
} | ||
|
||
/// <inheritdoc /> | ||
public new bool Equals(object? x, object? y) | ||
{ | ||
if (x is null) | ||
{ | ||
return y is null; | ||
} | ||
|
||
if (y is null) | ||
{ | ||
return false; | ||
} | ||
|
||
// We should deliberately make different types not equal to avoid type definition mismatch. | ||
// Object of type B that matched through A.Equal(B) can be accessed in JS through description of type A, which is wrong. | ||
if (x.GetType() != y.GetType()) | ||
{ | ||
return false; | ||
} | ||
|
||
return x.Equals(y); | ||
} | ||
|
||
/// <inheritdoc /> | ||
public int GetHashCode(object? obj) | ||
{ | ||
if (obj is null) | ||
{ | ||
return 0; | ||
} | ||
|
||
return obj.GetHashCode(); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right, and is different from what was discussed. It will return the wrong result for two (equal) instances of the same class, as in the original problem scenario you described.
If
x
is a reference type then we want to use reference equality, as in the original iteration of this PR. Ifx
is a (boxed) value-type then we want to use value equality. (Value equality should fail if the values are different types.)I think this should work, but it might need some testing: