Fix base class TS namespace

microsoft · Aug 15, 2024 · dd499be · dd499be
1 parent a14114e
commit dd499be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/NodeApi.Generator/TypeDefinitionsGenerator.cs b/src/NodeApi.Generator/TypeDefinitionsGenerator.cs
@@ -1897,9 +1897,12 @@ private string FormatTSType(
         NullabilityInfo? nullability,
         bool allowTypeParams = true)
     {
+        // Types exported from a module are not namespaced.
+        string nsPrefix = !_isModule && type.Namespace != null ? type.Namespace + '.' : "";
+
         string tsType = type.IsNested ?
             GetTSType(type.DeclaringType!, null, allowTypeParams) + '.' + type.Name :
-            (type.Namespace != null ? type.Namespace + '.' + type.Name : type.Name);
+            nsPrefix + type.Name;
 
         int typeNameEnd = tsType.IndexOf('`');
         if (typeNameEnd > 0)

diff --git a/test/TypeDefsGeneratorTests.cs b/test/TypeDefsGeneratorTests.cs
@@ -198,7 +198,7 @@ public void GenerateGenericClass()
             /** generic-class */
             export class GenericClass$1<T> implements GenericInterface$1<T> {
             	/** constructor */
-            	new(value: T): GenericClass$1<T>;
+            	constructor(value: T);
 
             	/** instance-property */
             	TestProperty: T;