This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add support for @nni.training_update in codegen #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Sep 21, 2019
| @@ -79,7 +80,8 @@ def parse_annotation_mutable_layers(code, lineno, nas_mode): | |||
| fields['optional_inputs'] = True | |||
| elif k.id == 'optional_input_size': | |||
| assert not fields['optional_input_size'], 'Duplicated field: optional_input_size' | |||
| assert type(value) is ast.Num or type(value) is ast.List, 'Value of optional_input_size should be a number or list' | |||
| assert type(value) is ast.Num or type( | |||
| value) is ast.List, 'Value of optional_input_size should be a number or list' | |||
There was a problem hiding this comment.
suggest switching to a new line after ast.List,
xuehui1991
approved these changes
Sep 27, 2019
liuzhe-lz
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1560, and prettify some of the codes to conform with PEP 8.