Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Minor fix suggested in Recommenders repo #86

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Conversation

AbhiramE
Copy link
Contributor

@AbhiramE AbhiramE commented Jun 6, 2019

Update floor division to division based on the comment received in Recommenders repo.

no, using math is fine, but the // operator does integer division which will round down (10 // 3 = 3), so the ceil is not actually doing anything. but if you do (10 / 3 = 3.333) then apply ceil you will get 4 which is what I'm assuming you want.

recommenders-team/recommenders#813 (comment)

@AbhiramE AbhiramE requested a review from saidbleik June 6, 2019 19:50
@saidbleik saidbleik merged commit b040c48 into staging Jun 6, 2019
@AbhiramE AbhiramE deleted the abhiram-requests-fix branch June 6, 2019 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants