Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF-A][TPM] Add the Internal TPM CRB Address to the .dec #361

Conversation

Raymond-MS
Copy link

Description

The TPM Service running in the secure partition will need to know the address of the internal CRB buffer for copying TPM data to/from the actual MMIO CRB. Added the address as a PCD in the .dec for SecurityPkg.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Verified by enabling TPM support through the TPM defines and running the TPM service.

Integration Instructions

N/A

…vice needs access to the library. Added the internal CRB address as a PCD for the TPM service
@Raymond-MS Raymond-MS requested a review from kuqin12 December 17, 2024 19:45
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/ffa_enablement@a2cc780). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/ffa_enablement    #361   +/-   ##
========================================================
  Coverage                          ?   1.42%           
========================================================
  Files                             ?     160           
  Lines                             ?   37422           
  Branches                          ?     273           
========================================================
  Hits                              ?     535           
  Misses                            ?   36887           
  Partials                          ?       0           
Flag Coverage Δ
SecurityPkg 0.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raymond-MS Raymond-MS merged commit 64ba950 into microsoft:feature/ffa_enablement Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants