Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MockTcgPpiLib #345

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Conversation

PaddyDengKC
Copy link
Contributor

@PaddyDengKC PaddyDengKC commented Oct 15, 2024

Description

To provide google test mock of TcgPpi

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested on other consumer package that can leverage the MockTcgPpiLib for google test.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Oct 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.43%. Comparing base (da561a3) to head (46853d7).

Additional details and impacted files
@@            Coverage Diff             @@
##           dev/202405    #345   +/-   ##
==========================================
  Coverage        1.43%   1.43%           
==========================================
  Files             159     159           
  Lines           37189   37189           
  Branches          273     273           
==========================================
  Hits              535     535           
  Misses          36654   36654           
Flag Coverage Δ
SecurityPkg 0.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 requested a review from VivianNK October 18, 2024 18:53
@apop5
Copy link
Contributor

apop5 commented Oct 18, 2024

Is there a corresponding PR into EDK2 to add this file there?

@PaddyDengKC
Copy link
Contributor Author

Is there a corresponding PR into EDK2 to add this file there?

No, we only add this mock in here.

@VivianNK
Copy link
Contributor

Is there a corresponding PR into EDK2 to add this file there?

No, we only add this mock in here.

For this change and all mocks moving forward, please create a PR to edk2 first.
GoogleTest Guide

@PaddyDengKC
Copy link
Contributor Author

Is there a corresponding PR into EDK2 to add this file there?

No, we only add this mock in here.

For this change and all mocks moving forward, please create a PR to edk2 first. GoogleTest Guide

Created tianocore/edk2#6363.
Once the PR in the EDK2 repo completed I will update in this PR.

@VivianNK VivianNK self-requested a review October 25, 2024 17:40
@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Nov 1, 2024
@VivianNK VivianNK enabled auto-merge (rebase) November 8, 2024 18:39
@VivianNK VivianNK merged commit 9431514 into microsoft:dev/202405 Nov 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants