SecurityPkg: Add measurement of Firmware Debugger Enabled based on DeviceState #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
os-d
reviewed
Oct 3, 2024
makubacki
reviewed
Oct 3, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
ea29d01 to
da77870
Compare
VivianNK
changed the title
github-actions
bot
added
the
impact:breaking-change
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
7e9afb2 to
db307d6
Compare
5 tasks
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
db307d6 to
c1f3c50
Compare
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
c1f3c50 to
f41990e
Compare
VivianNK
commented
Oct 14, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
2 times, most recently
from
f7035d9 to
0571edd
Compare
os-d
reviewed
Oct 14, 2024
os-d
reviewed
Oct 14, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
0571edd to
f864518
Compare
VivianNK
changed the title
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
3 times, most recently
from
279fb41 to
aa58612
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #342 +/- ##
=============================================
- Coverage 1.44% 1.44% -0.01%
=============================================
Files 159 159
Lines 37091 37126 +35
Branches 273 273
=============================================
Hits 535 535
- Misses 36556 36591 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VivianNK
changed the title
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
aa58612 to
b461728
Compare
Flickdm
requested changes
Oct 21, 2024
os-d
approved these changes
Oct 21, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
2 times, most recently
from
8836d16 to
439b9b7
Compare
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
439b9b7 to
22c0a4d
Compare
5 tasks
Flickdm
approved these changes
Oct 22, 2024
VivianNK
commented
Oct 22, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
22c0a4d to
25fbda0
Compare
makubacki
reviewed
Oct 22, 2024
makubacki
approved these changes
Oct 22, 2024
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
3 times, most recently
from
1aef220 to
f58639c
Compare
Enabled based on DeviceState. Added both to Tcg2Pei and Tcg2Dxe. The measurement is redundant in Tcg2Dxe, but is added for consistency with Tcg2Pei. The plan is to remove the PcdFirmwareDebuggerInitialized PCD and replace its usage with the DeviceStateLib This will prevent the system from booting if the device is in an an insecure state, as determined by the DeviceStateLib from MdeModulePkg. Signed-off-by: Vivian Nowka-Keane <[email protected]>
VivianNK
force-pushed
the
personal/vnowkakeane/insecureDeviceState
branch
from
f58639c to
bb9e989
Compare
github-actions
bot
added
the
impact:non-functional
os-d
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add measurement of Firmware Debugger
Enabled based on DeviceState.
Added both to Tcg2Pei and Tcg2Dxe. The measurement is redundant
in Tcg2Dxe, but is added for consistency with previous functionality.
The plan is to remove the PcdFirmwareDebuggerInitialized PCD
and replace its usage with the DeviceStateLib
This will prevent the system from booting if the device is in an
an insecure state, as determined by the DeviceStateLib from
MdeModulePkg.
How This Was Tested
Local CI
Integration Instructions
N/A