-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PcBdsPkg: Fix previous CodeQL change (51c7dc2) #280
Merged
kenlautner
merged 5 commits into
microsoft:release/202302
from
kenlautner:personal/klautner/additional_codeql_fixes
Aug 8, 2023
Merged
PcBdsPkg: Fix previous CodeQL change (51c7dc2) #280
kenlautner
merged 5 commits into
microsoft:release/202302
from
kenlautner:personal/klautner/additional_codeql_fixes
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Does not have a functional impact
label
Aug 4, 2023
kenlautner
changed the title
Fixed mistake in previous codeql fix where a returned NULL value is e…
Fix previous codeql changes
Aug 4, 2023
makubacki
added
type:bug
Something isn't working
and removed
impact:non-functional
Does not have a functional impact
labels
Aug 4, 2023
makubacki
reviewed
Aug 4, 2023
makubacki
reviewed
Aug 4, 2023
makubacki
approved these changes
Aug 4, 2023
makubacki
changed the title
Fix previous codeql changes
PcBdsPkg: Fix previous CodeQL change (51c7dc2)
Aug 4, 2023
os-d
approved these changes
Aug 8, 2023
apop5
approved these changes
Aug 8, 2023
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Aug 16, 2023
Introduces 7 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/bd77aef2e0ea5bdf22ddd9070811b9e5c875e67f">bd77ae</a> Repo File Sync: Update to Mu DevOps 5.0.6 and Ubuntu container 3bf70b5 (<a href="https://github.com/microsoft/mu_plus/pull/278">#278</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/365843ca00fd406d6e03e40be11883ebd7094078">365843</a> Add a check on the `PcdAdvancedFileLoggerFlush` for exit boot services (<a href="https://github.com/microsoft/mu_plus/pull/277">#277</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/e3527a304392a00fea08b39ab885529cd542d898">e3527a</a> pip: bump edk2-pytool-extensions from 0.23.9 to 0.23.10 (<a href="https://github.com/microsoft/mu_plus/pull/279">#279</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/25aedad81d6b72cd4d85b9653f62a742061f0db9">25aeda</a> PcBdsPkg: Fix previous CodeQL change (51c7dc2) (<a href="https://github.com/microsoft/mu_plus/pull/280">#280</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/519500d7b211e8f5cbcd2c9075b88e80a2dff65a">519500</a> pip: bump edk2-pytool-library from 0.15.3 to 0.16.1 (<a href="https://github.com/microsoft/mu_plus/pull/284">#284</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/8e93f0dfc998c80a05c66be32de53759a908908c">8e93f0</a> pip: bump regex from 2023.6.3 to 2023.8.8 (<a href="https://github.com/microsoft/mu_plus/pull/283">#283</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/546a06cd8175b35f5f22cca2233c1445abe4bb83">546a06</a> MsGraphicsPkg/FrameBufferMemDrawLib: Fix function declaration mismatch (<a href="https://github.com/microsoft/mu_plus/pull/282">#282</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a previous CodeQL fix (51c7dc2) that was checking for NULL return values. In this case a NULL return value is valid so instead of returning a bogus boot option let the function continue.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Tested on Physical hardware devices to confirm boot. Also confirmed CodeQL passes.
Integration Instructions
N/A